-
Notifications
You must be signed in to change notification settings - Fork 115
Add support for chat_completion task in Azure OpenAI integration #5796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for chat_completion task in Azure OpenAI integration #5796
Conversation
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
…mpletion-integration
…mpletion-integration # Conflicts: # output/openapi/elasticsearch-openapi.json # output/openapi/elasticsearch-serverless-openapi.json # output/schema/schema.json # specification/inference/put/PutRequest.ts
| }, | ||
| "dependencies": { | ||
| "@redocly/cli": "^1.34.5" | ||
| "@redocly/cli": "^1.34.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this change wasn't intentional, but we probably shouldn't be updating dependencies as part of adding docs for the inference API.
| */ | ||
| user?: string | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line 819 above this, "For a `completion` or `text_embedding` task" should be "For a `completion`, `chat_completion` or `text_embedding` task"
| * * Anthropic (`completion`) | ||
| * * Azure AI Studio (`completion`, `rerank`, `text_embedding`) | ||
| * * Azure OpenAI (`completion`, `text_embedding`) | ||
| * * Azure OpenAI (`completion`, `chat_completion`, `text_embedding`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but could these be in alphabetical order like for the other providers?
| "type": "enum", | ||
| "description": "The task type", | ||
| "options": ["completion", "text_embedding"] | ||
| "options": ["completion", "chat_completion", "text_embedding"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but could these be in alphabetical order?
This PR adds changes to specification caused by elastic/elasticsearch#138726
Additional actions